Skip to content

chore!: Enable and fix a few pedantic and nursery clippy lints#1186

Merged
sbernauer merged 21 commits intomainfrom
chore/pedantic-clippy-lints
Apr 9, 2026
Merged

chore!: Enable and fix a few pedantic and nursery clippy lints#1186
sbernauer merged 21 commits intomainfrom
chore/pedantic-clippy-lints

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Mar 31, 2026

Description

See Cargo.toml on what lints are now enabled. They apply to all workspace members.

Some lints we want to enable in the future, but for now I'm ignoring them, as the PR is big enough already with the easy ones.
E.g. we need to think about many possible number truncations.

I suggest reviewing the commits one by one. Some lints have been auto-corrected (--fix), some manually.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer changed the title chore: Enable and fix a few pedantic and nursery clippy lints chore!: Enable and fix a few pedantic and nursery clippy lints Apr 1, 2026
@sbernauer sbernauer marked this pull request as ready for review April 1, 2026 08:51
@sbernauer sbernauer self-assigned this Apr 1, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Apr 1, 2026
@sbernauer sbernauer requested a review from a team April 1, 2026 10:16
@Techassi Techassi self-requested a review April 1, 2026 10:17
xeniape
xeniape previously approved these changes Apr 9, 2026
Copy link
Copy Markdown
Member

@xeniape xeniape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor things

Co-authored-by: Xenia <xeniafischer@hotmail.de>
@sbernauer sbernauer requested a review from xeniape April 9, 2026 10:49
@sbernauer sbernauer added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit ea49d1b Apr 9, 2026
5 checks passed
@sbernauer sbernauer deleted the chore/pedantic-clippy-lints branch April 9, 2026 11:19
@Techassi Techassi moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

3 participants